search

Juan571 / js2-mode

Automatically exported from code.google.com/p/js2-mode
0 stars 0 forks source link

Default font locking is color-theme unfriendly #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Install color theme
2. Eval (color-theme-charcoal-black)
3. Load a file in js2-mode

What is the expected output? What do you see instead?
See attached for a comparison with javascript-mode (proper coloring is seen
on the left side). Note that nxml-mode seems to pick up the color-theme
colors properly without being in the font-lock-mode camp.

What version of the product are you using? On what operating system?
js2-20080330.el
GNU Emacs 22.1.90.1 (i386-mingw-nt6.0.6001) of 2008-02-05 on NOTEBOOK

Please provide any additional information below.
This mode looks awesome, can't wait to explore it further.

Original issue reported on code.google.com by dereksla...@gmail.com on 31 Mar 2008 at 5:51

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Well, it appears that you've thought of everything. A closer inspection finds 
the
following variable. All is right with the world.

js2-use-font-lock-faces

Original comment by dereksla...@gmail.com on 31 Mar 2008 at 6:11

GoogleCodeExporter commented 8 years ago 
Thank you, it doesn't happen often, that the author foresees that others might 
have
different needs. This is how software should be written. It is just a simple 
thing,
but it made me realize, how often I write sloppy code.

Thanks.

Original comment by palomu...@gmail.com on 31 Mar 2008 at 8:19

GoogleCodeExporter commented 8 years ago 
(js2-use-font-lock-faces t) should be the default. The behavior is surprising 
otherwise.

Original comment by dcl...@gmail.com on 5 Apr 2008 at 8:50

GoogleCodeExporter commented 8 years ago 
I had some troubles with this as well, and could only get it to work if I set
js2-use-font-lock-faces to t *before* doing (require 'js2-mode). It's probably 
worth
mentioning if someone else has the same problem.

Original comment by fredrik....@gmail.com on 10 Apr 2008 at 7:42

GoogleCodeExporter commented 8 years ago 
Fixed in 20080413 release.

Original comment by steve.ye...@gmail.com on 14 Apr 2008 at 10:02