search

JuanDBta / ToDoList-Project

My To Do List project is a task management application that allows you to create, delete, and edit tasks. It utilizes local storage to store the tasks. The project features a "Clear all completed" button that removes all checked tasks and displays the remaining unfinished tasks. It was implemented using HTML, CSS and JS, with webpack for bundle.
https://juandbta.github.io/ToDoList-Project/
MIT License
4 stars 0 forks source link

DRY, KISS, and YAGNI rules #10

Open JuanDBta opened 1 year ago

JuanDBta commented 1 year ago

Reviewing my code having in mind DRY, KISS, YAGNI rules. Let see what we find.

JuanDBta commented 1 year ago

In order to accomplish DRY & KISS rules, please review your indentation in order to make your code more readable and simpler: https://github.com/JuanDBta/ToDoList-Project/blob/e1f31798426be06b35c8eb0f1b52008929368d37/src/modules/task_class.js#L18-L25

JuanDBta commented 1 year ago

Other suggestion I can give you for your code in order to accomplish DRY, KISS & YAGNI rules is to refactor your functions like this https://github.com/JuanDBta/ToDoList-Project/blob/e1f31798426be06b35c8eb0f1b52008929368d37/src/modules/task_class.js#L12-L16

to arrow functions.