search

JuanDBta / ToDoList-Project

My To Do List project is a task management application that allows you to create, delete, and edit tasks. It utilizes local storage to store the tasks. The project features a "Clear all completed" button that removes all checked tasks and displays the remaining unfinished tasks. It was implemented using HTML, CSS and JS, with webpack for bundle.
https://juandbta.github.io/ToDoList-Project/
MIT License
4 stars 0 forks source link

Peer-to-peer code review #2

Open DRT-DISABLED-ACCOUNT opened 1 year ago

DRT-DISABLED-ACCOUNT commented 1 year ago

👋 Juan

Great job with the project, the space background looks amazing 🪐

Suggestions

Please consider to make the following changes 👇

Webpack

Please update the main entry as a value a not as an object:

  entry: './src/index.js',

Please remove optimizations and runtimeChunk, you don't have multiple entry points, so you don't need to have it:

  optimization: {
    runtimeChunk: 'single',
  },

Please add assets management for images and fonts:

{
        test: /\.(png|svg|jpg|jpeg|gif)$/i,
        type: 'asset/resource',
      },
      {
        test: /\.(woff|woff2|eot|ttf|otf)$/i,
        type: 'asset/resource',
      },
JuanDBta commented 1 year ago

Thank you Juan, great suggestions, I already added it.