search

JuanDBta / my-portfolio

My Portfolio Project is a website showcasing my projects. It includes a Contact and About Me sections and links to my social media. You can view the programming languages I work with. It's responsive, with a Mobile and Desktop version. Built with HTML, CSS, Flexbox, and Grid Layout.
https://juan-diaz.me/#
MIT License
3 stars 0 forks source link

Peer-to-peer code review #12

Open DRT-DISABLED-ACCOUNT opened 1 year ago

DRT-DISABLED-ACCOUNT commented 1 year ago

👋Juan David

Great job with the popup! Just one small suggestion: to ensure that the popup works smoothly, it's a good practice to set the position property of the parent container to fixed in the CSS file. Additionally, you can set the overflow property of the body element to hidden when the popup is open, and then set it back to auto when the popup is closed. This will allow users to scroll inside the popup while keeping the background still. Keep up the good work!

JuanDBta commented 1 year ago

Hey Juan, great suggestion! Thank you very much for that, I will apply it...