Browser support - Githubissues

JuanIrache / gopro-telemetry

Reads telemetry from the GPMF track in GoPro cameras (Hero5 and later) and converts it to multiple formats

MIT License

315 stars 57 forks source link

Closed Akxe closed 1 year ago

Akxe commented 1 year ago

Polyfilled setImmediate
Added many browser tests (all that test the exposed function)
Exposed the function under name exports too
Removed unnecessary libraries
- atob - it got replaced by String.fromCharCode. It was not even browser compatible...
- @gmod/binary-parser in favour of binary-parser. The current version does support Int64 so there is no need to use a fork. The current library also supports Uint8Array as input.
Fixed the Reused parsed data should output the same as binary data test as it was comparing Promise instead of its value

Akxe commented 1 year ago

@JuanIrache I think the CI crashes because the node version is too low...

It is now ready to be merged (on my part)

JuanIrache commented 1 year ago

Thanks for all the work!

The CI is crashing on one of the browser tests (even after updating the Node image). Could you have a look?

Akxe commented 1 year ago

The whole test suite took 7s on my PC, and out of this time, 5.5s is the browser testing. Maybe the GoPro11 test takes simply too long.

The upload of the hero11.raw is the part that is hanging the longest (hypothesis). hero7.raw and hero11.raw are biggest files.

JuanIrache commented 1 year ago

I will try to replace those samples. Not sure I can find a smaller HERO7 sample that works for those tests, though

Akxe commented 1 year ago

I would simple increase the time...