search

JuanLPalacios / capstone-project-1

A simple implementation of responsive design for mobile and desktop including home and about pages for the fictional "Computer Graphics Conference 2022" it also has a simple implementation of a mobile collapsable list and popup menu based on hash navigation events.
10 stars 3 forks source link

Peer-to-peer code review #7

Open LuisSalas94 opened 2 years ago

LuisSalas94 commented 2 years ago
Kakalanp commented 2 years ago

Congratulations! Your project looks great! 🎉

I'd like to highlight the attention to details 🔍, it truly makes your project shine! ✨

There's only one small 🤏 detail that you could improve: image As you can see, in OperaGX the Hamburger button is invisible, this is because this browser doesnt support Backdrop-filter 🧐https://github.com/JuanLPalacios/capstone-project-1/blob/4198065743a8b402f16372eb2691a10342bc7ff4/css/main.css#L328-L332

But worry not 😉.

A quick fix to this issue could be the following: https://github.com/JuanLPalacios/capstone-project-1/blob/4198065743a8b402f16372eb2691a10342bc7ff4/css/main.css#L331 maybe move this part of your code to a @supports(), and just use a background color as default property, like so: image this way, browsers like OperaGX would be able to show your button with no problem! 😁.

I hope this doesn't take much of your time, and, in any case, good look implementing the necessary changes! 🍀