Use the output parameter

JuanPotato / Legofy

Make images look as if they are made out of 1x1 LEGO blocks

MIT License

3.16k stars 189 forks source link

Use the output parameter #21

Closed Brobin closed 9 years ago

Brobin commented 9 years ago

Changes

Pass the output parameter to the main method
Check if it is set, otherwise prepend lego_
Remove file extension manipulation so the user can specify it
Add unit tests :shipit:

Closes #15

JuanPotato commented 9 years ago

Only one problem with this, jpg encoding doesn't work on every system. without installing a few extras at times, in my experience, so setting it as png was my workaround. When someone uses --output new_image.jpg it is not certain that it will work correctly.

JuanPotato commented 9 years ago

well I attempted to merge this while fixing conflicts and failed...

Brobin commented 9 years ago

No problem, it looks like you have a lot of people helping out

JuanPotato commented 9 years ago

Yeah, this is the first time I made a program that got popular, so I don't have much experience with github anyway. It's been really nice seeing the program develop with other people's ideas.

Brobin commented 9 years ago

Yeah, it's pretty fun to work on projects with people from all over!

JuanPotato commented 9 years ago

Indeed, I wonder what my next project will be.