search

JuanPotato / Legofy

Make images look as if they are made out of 1x1 LEGO blocks
MIT License
3.16k stars 189 forks source link

Refactor and improvements #54

Closed niroyb closed 9 years ago

niroyb commented 9 years ago

Fail early on Windows if there is no MAGICK_HOME env var. Fix bug where gif would use frames of a previous run if the previous run was canceled. Fix failure exit return codes.

JuanPotato commented 9 years ago

I only have one comment, why do you have most variables snake_case but then left plenty in camelCase?

JuanPotato commented 9 years ago

Now if only I can go through all this without getting confused again, then I will merge it, Great work! I need to go to sleep

JuanPotato commented 9 years ago

Just found out btw, using call("convert", shell=True) makes python use ImageMagick convert, adding this soon or you can

niroyb commented 9 years ago

Thanks, I'd recommend not using shell=True. It opens the code to many vulnerabilities. http://stackoverflow.com/questions/3172470/actual-meaning-of-shell-true-in-subprocessEven the doc recommends against it. https://docs.python.org/2/library/subprocess.html#using-the-subprocess-module

Nick

On 1 November 2015 at 19:48, Juan Potato notifications@github.com wrote:

Just found out btw, using call("convert", shell=True) makes python use ImageMagick convert, adding this soon or you can

— Reply to this email directly or view it on GitHub https://github.com/JuanPotato/Legofy/pull/54#issuecomment-152904677.

JuanPotato commented 9 years ago

I understand, I wonder if there is another way to bypass the windows convert or find the ImageMagick dir more reliably.