search

JuanPotato / Legofy

Make images look as if they are made out of 1x1 LEGO blocks
MIT License
3.15k stars 189 forks source link

Add more tests, drop 3.2 not supported by click #65

Closed niroyb closed 9 years ago

nabijaczleweli commented 9 years ago

Looks good to me.

(also +1000 for that bacon)

niroyb commented 9 years ago

Thanks! Any idea when this is going to be merged or what other work has to be done?

JuanPotato commented 9 years ago

I'm just wondering what we can do about 3.2, and I am trying to to include big files like gifs in the github so that it can clone quicker

niroyb commented 9 years ago

You could remove the dependency to click or add 3.2 support to click. The reason they dropped 3.2 is PEP 0414. This should be in a different pull request since it is unrelated.

The gif is 1.3 Mb, there is only one for testing purposes and it is only downloaded once when cloning. Cloning quicker is not a valid argument : It takes travis 0.7 seconds to clone with the gif...

On 6 November 2015 at 15:22, Juan Potato notifications@github.com wrote:

I'm just wondering what we can do about 3.2, and I am trying to to include big files like gifs in the github so that it can clone quicker

— Reply to this email directly or view it on GitHub https://github.com/JuanPotato/Legofy/pull/65#issuecomment-154574689.

JuanPotato commented 9 years ago

With my internet speed, It takes an awkward amount of time to clone the 5mb that is the git now (I need to remove some deleted files), so it is a valid argument, but its not terrible. I'll merge, might replace the gif with a smaller one later

niroyb commented 9 years ago

Thanks, a shallow git clone is faster since it does not download the history. Again, it only has to be done once. Replacing with a smaller one is also a good idea.