Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.59k stars 1.11k forks source link

The text of uilabel does not change when it is in showAnimatedSkeleton. #330

Closed greatsk55 closed 4 years ago

greatsk55 commented 4 years ago

Description

The text of uilabel does not change when it is in showAnimatedSkeleton. i'm using storyboard.

ex )

vc view---------- baba(label)
------------------
view.showAnimatedSkeleton(usingColor: .clouds, animation: .none, transition: .none)
label.text = "haha"
view.hideSkeleton()

label text is still baba.

What type of issue is this? (place an x in one of the [ ])

Requirements (place an x in each of the [ ])


Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

SkeletonView Environment:

SkeletonView version: Xcode version: Swift version:

Steps to reproduce:

Please replace this with the steps to reproduce the behavior.

1. 2. 3.

Expected result:

Please replace this with what you expected to happen.

Actual result:

Please replace this with of what happened instead.

Attachments:

Logs, screenshots, sample project, funny gif, etc.

Juanpe commented 4 years ago

Hi @greatsk55 , the next version will fix this problem.

If you want to check if the problem is solved with this fix you can set the dependency in your podfile, pointing to the develop branch.

Podfile pod 'SkeletonView', :git => 'https://github.com/Juanpe/SkeletonView.git', :branch => 'develop'

Juanpe commented 4 years ago

SkeletonView v1.10 has been released, so you don't need to modify your podfile :)