Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.59k stars 1.11k forks source link

Version 1.9 breaks swift package manager #332

Closed BrentMifsud closed 4 years ago

BrentMifsud commented 4 years ago

Description

1.9 is not a semantic version number. As such SPM cannot resolve.

Please update/create a new tag 1.9.0

Using the commit SHA from 1.9 works, and any other tag works.

What type of issue is this? (place an x in one of the [ ])

Requirements (place an x in each of the [ ])


Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

SkeletonView Environment:

SkeletonView version: 1.9 Xcode version: 12.0 Swift version: 5.3

Steps to reproduce:

  1. Xcode -> file -> Swift packages -> Add package dependency
  2. Set exact version to 1.9
  3. observe failure

Expected result:

package should resolve successfully

Actual result:

package fails to resolve

Attachments:

image

image

Juanpe commented 4 years ago

Hi @BrentMifsud! Thanks for reporting. We're going to create a new tag to solve this problem

Juanpe commented 4 years ago

Hi again, this issue should be resolved :) Feel free to open a new issue if you have another problem

Screenshot 2020-09-18 at 10 48 57