Closed yzhao198 closed 3 years ago
Hi @yzhao198, thanks for your first contribution. I've checked the code and it looks perfect.
There is only one thing to do before merging. You should update the CHANGELOG file including this PR, ok?
Thanks again
Thanks for your review @Juanpe I've updated CHANGELOG.md.
Summary
Thank you for writing this library. Here is a snippet of code I used when testing
SkeletonView
:The desired result should be
but the current version (1.10.0) gives me
Given my testing device is NOT RTL, it is clear the padding is incorrectly rendered. After the changes made in this MR, the desired result is achieved.
Requirements (place an
x
in each of the[ ]
)