Fixed: SkeletonView respecting Font's height, rather than the `UIView…

Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting

MIT License

12.59k stars 1.11k forks source link

Fixed: SkeletonView respecting Font's height, rather than the `UIView… #359

Closed keshavamurthy1 closed 3 years ago

keshavamurthy1 commented 3 years ago

…` actual height #353

Summary

Fixed #353 Using Label height from the HeightConstraint if there is any HeightConstraint set instead of the Label Font line height if no HeightConstraint set, will be using SkeletonAppearance.default.multilineHeight as it was before

Requirements (place an `x` in each of the `[ ]`)

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

RuiAAPeres commented 3 years ago

Nice. 👏

Juanpe commented 3 years ago

Hi @keshavamurthy1 thanks for contributing :)

Juanpe / SkeletonView

Fixed: SkeletonView respecting Font's height, rather than the `UIView… #359

Summary

Requirements (place an x in each of the [ ])

Requirements (place an `x` in each of the `[ ]`)