update the placeholder to use an empty space

Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting

MIT License

12.53k stars 1.1k forks source link

update the placeholder to use an empty space #389

Closed michaelhenry closed 3 years ago

michaelhenry commented 3 years ago

Summary

in iOS12, this placeholder is still appearing before the skeleton view appears and will disappear immediately. (but it's still visible and recognizable)

close #388

This also prevents having a bigger skeleton view than what is actually needed.

Requirements (place an `x` in each of the `[ ]`)

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

Juanpe commented 3 years ago

Hi @michaelhenry, thanks for the contribution 👏🏼

Looks great! it'll be included in the next version 😄

Juanpe / SkeletonView

update the placeholder to use an empty space #389

Summary

Requirements (place an x in each of the [ ])

Requirements (place an `x` in each of the `[ ]`)