Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.53k stars 1.1k forks source link

SkeletonCollectionDelegate doesn't call identifierForFooterInSection anymore #393

Closed Spaalvast closed 3 years ago

Spaalvast commented 3 years ago

Description

When implementing the collectionSkeletonView:identifierForFooterInSection protocol it will never get called.

Cause: In the file 'SkeletonCollectionDelegate.swift' and the method 'tableView:viewForFooterInSection' the 'identifierForHeaderInSection' is called instead of the footer as would be expected.

What type of issue is this? (place an x in one of the [ ])

Requirements (place an x in each of the [ ])


Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

SkeletonView Environment:

SkeletonView version: 1.15.0 Xcode version: 12.4 Swift version: 5

Steps to reproduce:

  1. Download the example project
  2. Place a break point at the implantation of the 'identifierForFooterInSection'
  3. Run the app and notice it will never triggger

Expected result:

Able to remove the footer skeleton by not implementing the method or returning nil.

Actual result:

If you have a header, it will also always show a footer.

Attachments:

Logs, screenshots, sample project, funny gif, etc.

Juanpe commented 3 years ago

Hi @Spaalvast, thanks for open this issue. It's already solved, there was a problem with the delegate implementation. You can find more details in the PR #394