search

Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.53k stars 1.1k forks source link

Add SkeletonCollectionDataSource.automaticNumberOfRows Constant #401

Closed rlziii closed 3 years ago

rlziii commented 3 years ago

Summary

Add a new SkeletonCollectionDataSource.automaticNumberOfRows constant that can be returned from tableView(_:numberOfRowsInSection:) or collectionView(_:numberOfItemsInSection:) to allow for the default behavior (i.e. estimatedNumberOfRows to be returned). This will help with abstractions around SkeletonTableViewDataSource and SkeletonCollectionViewDataSource to be more customizable.

Closes #400

Requirements (place an x in each of the [ ])

github-actions[bot] commented 3 years ago
Warnings
:warning: Consider **also** updating the README for other languages.

Generated by :no_entry_sign: Danger Swift against 6874c3667154e1bd05f68c7455dc633d5aa97587

Juanpe commented 3 years ago

Wow!! you're so fast 🚀 Congrats on your first contribution! 😄

The code LGTM, I've just added a suggestion in order to highlighted the message in the README file.

Thanks!

rlziii commented 3 years ago

Wow!! you're so fast 🚀 Congrats on your first contribution! 😄

The code LGTM, I've just added a suggestion in order to highlighted the message in the README file.

Thanks!

That suggestion makes perfect sense to me; easy for the comment to get lost in the void otherwise. And thank YOU for making such a great library to use for everyone to use! It will really speed up our development time!