Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.53k stars 1.1k forks source link

Skeleton view not aligned properly in RTL #407

Closed Prempriya08 closed 2 years ago

Prempriya08 commented 3 years ago

IMG_0828 IMG_0827 In english its working fine but when checking in arabic. The skeleton view gets distorted. Please, help me.

yousefelsayed commented 3 years ago

Hi @Prempriya08 Did you find a solution to this issue? it's happening with me also .

Juanpe commented 3 years ago

Hi! could you give more context? SkeletonView version, iOS version... I've tried to reproduce this issue but I can't. Thanks

Screenshot 2021-06-22 at 09 39 52 Example app screenshot

stale[bot] commented 3 years ago

🤖 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙂

yousefelsayed commented 3 years ago

Hi @Juanpe thanks for your reply , i faced same issue on RTL , the Skelton version i setup was latest version and the iOS is 14.3 , here is a screenshot from the behaviour that happened with me while scrolling image

Juanpe commented 3 years ago

It's so weird...I did some tests using the example app, and I couldn't reproduce it.

Could be a problem with the constraints? Could you show the constraints?

In the example app, the constraints look like this: Screenshot 2021-07-02 at 15 53 24

And the result is this:

Screenshot 2021-07-02 at 15 53 31

As you can see, the labels were rendered well.

There is something not clear for me. You said that this issue happens when you are scrolling?

yousefelsayed commented 3 years ago

@Juanpe here is my constraints all my labels on a vertical stackview , i use showAnimatedSkeleton function at cell content view image image

Juanpe commented 2 years ago

Hi @yousefelsayed, could you provide a sample project? I think it'll be useful to fix this issue faster :/

Prempriya08 commented 2 years ago

Constraints are properly aligned. the labels have leading, trailing, top and bottom but still it occurs when we come back and froth from one screen to other.

Juanpe commented 2 years ago

mmm... 🤔 this is another thing, so the problem is when you push/present another view and come back, doesn't it?

shivamsinha-quytech commented 2 years ago

Hi @Juanpe ,

I am also facing same issue in Arabic language (Which support RTL) randomly when we switch between screens. I attached screenshots please check

In English language Simulator Screen Shot - iPhone 8 - 2021-08-17 at 13 57 47

In Arabic language

Screenshot 2021-08-17 at 2 07 48 PM Screenshot 2021-08-17 at 2 07 58 PM

Cell with constraint (which have skeleton) Screenshot 2021-08-17 at 2 01 04 PM

Juanpe commented 2 years ago

Hi @shivamsinha-quytech, please, could you provide a sample project?

I'm trying to reproduce it, but I can't :/ https://user-images.githubusercontent.com/1409041/129776055-27c1701b-d8e1-4bc6-96a1-5120d89e16f3.mp4

shivamsinha-quytech commented 2 years ago

Hi Juanpe,

Thanks for quick response.

I think you are focusing only on LTR view but i am facing problem in RTL view. As my app is available in english and arabic both. So when i change the app language the semantic get changed to RTL mode and the complete screen get flipped. The issue starts happening after switching between the languages ENGLISH TO ARABIC or ARABIC to ENGLISH. It is very random.

Thanks

shivamsinha-quytech commented 2 years ago

Hi @Juanpe,

I think now you got my point so have you any update on this or you still need sample project.

Thanks

Juanpe commented 2 years ago

Hi @shivamsinha-quytech, yep, I think the sample project would help me to reproduce and fix the issue sooner. So, could you provide me one, please? 🤙🏼

Juanpe commented 2 years ago

Hi @shivamsinha-quytech, could you create the sample project? 🙂

shivamsinha-quytech commented 2 years ago

Hi @Juanpe sorry for late response. Please find sample project for reference.

For recreate problem Step 1 :- launch app Step 2:- change language from setting icon and you got the problem

SampleProjectForSkeleton.zip

Thanks

shivamsinha-quytech commented 2 years ago

Hi @Juanpe

any update on this ?

Thanks

shivamsinha-quytech commented 2 years ago

Hi @Juanpe

any update on this ?

Thanks

shivamsinha-quytech commented 2 years ago

Hi @Juanpe

any update on this ?

Thanks

Juanpe commented 2 years ago

Sorry for the late response. I'm going to check it asap 👍🏼 Thanks for the sample project

Juanpe commented 2 years ago

I've checked this issue in your sample project using the latest version (1.27.0) and it seems it's fixed. @shivamsinha-quytech, could you take a look please?

RTL LTR
stale[bot] commented 2 years ago

🤖 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙂