search

Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.53k stars 1.1k forks source link

Configure Cell Feature #412

Closed nemanjachoco closed 3 years ago

nemanjachoco commented 3 years ago

Describe the feature or problem you’d like to solve

Our codebase is modularized and have only one dependency on a protocol modules. We then inject the implementation from the main app, including one implementation to configure skeleton on cells. But because SkeletonView is creating UITableViewCell and passing it back directly there is no way for us to configure that cell.

Proposed solution

Add an optional method to SkeletonCollectionDataSource protocol that would allow us to configure cell that is created by SkeletonView. This method is optional can can be ignored which assure backward compatibility.

Additional context

All of this works is for UICollectionView as well.

PR Link

karim-alweheshy commented 3 years ago

+1

datoutwo commented 3 years ago

+1