Fix for bug 426 - Githubissues

Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting

MIT License

12.51k stars 1.1k forks source link

Fix for bug 426 #427

Closed ankitagarwal007 closed 2 years ago

ankitagarwal007 commented 2 years ago

Summary

Closes #426

Requirements (place an `x` in each of the `[ ]`)

[ x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x ] I've read and agree to the Code of Conduct.

Juanpe commented 2 years ago

Hi @ankitagarwal007 👋🏼

I was thinking about this PR and I think we should allow to the developers deciding if the library should use the font line for labels or not. So, I think we could create a new property, something like usesTextHeightForLabels. WDTY?

Juanpe commented 2 years ago

Congratulations! 🎉 This was released as part of SkeletonView 1.23.0 🚀

Juanpe / SkeletonView

Fix for bug 426 #427

Summary

Requirements (place an x in each of the [ ])

Requirements (place an `x` in each of the `[ ]`)