search

Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.59k stars 1.11k forks source link

Estimated height doesn't consider `tableView(_:estimatedHeightForRowAt:)` #448

Closed RobertDresler closed 2 years ago

RobertDresler commented 3 years ago

SkeletonView Environment:

SkeletonView version: 1.24.4 Xcode version: 12.5.1 Swift version: 5.4.2

Steps to reproduce:

  1. Set estimated height based on indexPath in tableView(_:estimatedHeightForRowAt:) method of UITableViewDelegate

Expected result:

SkeletonView will use this height as height for row. You can either implement taking estimated height for row from this method or creating some method like collectionSkeletonView(_:estimatedHeightForRowAt:)

Actual result:

SkeletonView uses just table view's .estimatedRowHeight property.

Juanpe commented 3 years ago

Hi @RobertDresler, I'm working on a solution for this. I'll let you know when it's ready 👍🏼

Juanpe commented 2 years ago

Duplicate of #424

Juanpe commented 2 years ago

I'm going to close this issue because it's duplicated with #424

Thanks