Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.51k stars 1.1k forks source link

TableView's insetGrouped style not work #463

Closed SoprachevAK closed 2 years ago

SoprachevAK commented 2 years ago

Description

Describe your issue here.

What type of issue is this?

Requirements


Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

SkeletonView Environment:

SkeletonView version: 1.25.2 Xcode version: 13.1 Swift version: 5

Steps to reproduce:

  1. Open ios example
  2. In Main.storyboard change Tableview style to insetGrouped
  3. In func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) change count of rows to 3 (or less screen height count)
  4. Build and Run application
  5. Tap on show/hide skeleton button with gradient animation

Expected result:

All work fine

Actual result:

  1. Skeleton didn't hide
  2. After hide and show skeleton again, animation on "added" cell is out of sync with existing ones
FrolovNV commented 2 years ago

Same problem

Juanpe commented 2 years ago

Hi @SoprachevAK @FrolovNV 👋🏼

Sorry, but I can't reproduce this issue 🤔 Could you provide a video or a sample project? Thanks

SoprachevAK commented 2 years ago

@Juanpe, I'm use clear project from latest main branch

https://user-images.githubusercontent.com/13734096/150033229-0377dc8c-7915-49da-926c-304263682927.mov

steve7688 commented 2 years ago

I had the same problem.I use inset grouped tableview from a storyboard. there are two custom cells. skeleton still working when I call hideSkeleton() method. @Juanpe

tomcheung commented 2 years ago

@Juanpe I can also reproduce this issue and create a PR #494 to fix that, please take a look

stale[bot] commented 2 years ago

🤖 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙂

tomcheung commented 2 years ago

@Juanpe Can you take a look on that?

codingiran commented 2 years ago

@Juanpe Same problem , if tableView is set to .insetGroup style, all cells are Wrapped by UITableViewWrapperView( _wrapperView). Maybe this cause the problem, hope can solve it. Thanks a lot!