Juanpe / SkeletonView

โ˜ ๏ธ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.51k stars 1.1k forks source link

HideSkeleton() does not apply transition within a UITableView #469

Open PlayDevelop opened 2 years ago

PlayDevelop commented 2 years ago

Description

The transition is broken when doing HideSkeleton(transition: .crossDisolve(TIME)) when the views is within a UITableView.

Same thing in Example app.

What type of issue is this? (place an x in one of the [ ])

Requirements (place an x in each of the [ ])


Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

SkeletonView Environment:

SkeletonView version: 1.26.0 Xcode version: 13.1 Swift version: 5.5.1

Steps to reproduce:

Please replace this with the steps to reproduce the behavior.

  1. Apply Skeleton views within UITableView cell
  2. Show Skeleton with crossdisolve of 1 sec
  3. Hide Skeleton with crossdisolve of 1 sec

Expected result:

Skeleton shows and hide with expected transition time

Actual result:

Skeleton shows with crossdisolve time of 1, and hide with no transition

Attachments:

Logs, screenshots, sample project, funny gif, etc.

Juanpe commented 2 years ago

Hi @PlayDevelop ๐Ÿ‘‹๐Ÿผ

You're right, I'm going to add it to the backlog to fix it asap ๐Ÿ‘๐Ÿผ

Thanks

shipinev commented 2 years ago

Hey @Juanpe. First of all, thank you for this easy-to-use library. Do you have any update on the issue fix?

Juanpe commented 2 years ago

Thanks, @shipinev. Not yet, sorry :/

JacksonJang commented 2 years ago

I fixed! Please check this solution. https://github.com/Juanpe/SkeletonView/pull/484