search

Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.51k stars 1.1k forks source link

Add ExampleViewController for programatically creating ViewController #475

Closed JacksonJang closed 2 years ago

JacksonJang commented 2 years ago

Summary

Describe the goal of this PR. Mention any related Issue numbers. issue link : https://github.com/Juanpe/SkeletonView/issues/474

I love "SkeletonView" Library. so I've seen this library issue since a year. I would like to contribute. .

Requirements (place an x in each of the [ ])

Juanpe commented 2 years ago

Hi @JacksonJang 👋🏼

Thanks for contributing. I like the example but I think the name should be more descriptive, something like: UITextViewByCodeViewController or something like that. WDYT?

JacksonJang commented 2 years ago

Hello~ Junape^^

Thanks for your answer! I'm glad every time when I receive your mail regarding git. "UITextViewByCodeViewController" is a good name, I think so!

Would I have to PR again to change the name?

Juanpe commented 2 years ago

Great!

No, you only need to modify the name and commit the changes 👍🏼

JacksonJang commented 2 years ago

I changed the name thanks to you!!