Juanpe / SkeletonView

☠️ An elegant way to show users that something is happening and also prepare them to which contents they are awaiting
MIT License
12.5k stars 1.1k forks source link

Add PrivacyInfo manifest file #552

Closed kdvmgn closed 5 months ago

kdvmgn commented 8 months ago

Summary

In this PR I added a PrivacyInfo manifest file which will be required starting Spring 2024 for all iOS application submitting to AppStore Connect. SkeletonView uses UserDefaults which is one of the APIs required to be listed in a Privacy manifest file with the reason why it is being used.

Associated issue: https://github.com/Juanpe/SkeletonView/issues/551

Screenshot 2023-11-03 at 10 27 14 AM

The file requires all four fields to be included:

Requirements (place an x in each of the [ ])

Juanpe commented 5 months ago

Thanks @kdvmgn for the contribution 👍🏼

hiragram commented 3 months ago

@Juanpe Do you have any plan to make a release including this patch?

slice-varundudeja commented 3 months ago

has this been released?

linhaosunny commented 3 months ago

Thanks @kdvmgn for the contribution 👍🏼

@Juanpe Any PrivacyInfo.xcprivacy Update for cocoapods .podspec ?

WGMB commented 3 months ago

Hi, please create new release version with the latest changes and a Cocoapods release as well.

slice-varundudeja commented 3 months ago

why is privacy file needed though? its not mentioned here. https://developer.apple.com/support/third-party-SDK-requirements/

WGMB commented 3 months ago

SkeletonView uses UserDefaults which is one of the APIs required to be listed in a Privacy manifest file.

slice-varundudeja commented 3 months ago

@WGMB https://developer.apple.com/support/third-party-SDK-requirements/

The following are commonly used SDKs in apps on the App Store. Starting in spring 2024, you must include the privacy manifest for any SDK listed below when you submit new apps in App Store Connect that include those SDKs, or when you submit an app update that adds one of the listed SDKs as part of the update. Signatures are also required in these cases where the listed SDKs are used as binary dependencies. Any version of a listed SDK, as well as any SDKs that repackage those on the list, are included in the requirement.

only for these third party libraries, we need to have privacy manifest is what i can understand from the above link. can you help here?

linhaosunny commented 3 months ago

Thanks @kdvmgn for the contribution 👍🏼

@Juanpe Any PrivacyInfo.xcprivacy Update for cocoapods .podspec ?

@kdvmgn Any commit for support cocoapods?

linhaosunny commented 3 months ago

I add PR for this podspec support [https://github.com/Juanpe/SkeletonView/pull/560#issue-2217440011]

slice-varundudeja commented 3 months ago

can someone help here? https://github.com/Juanpe/SkeletonView/pull/552#issuecomment-2024887166