search

JudahGabriel / RavenDB.Identity

RavenDB Identity provider for ASP.NET Core. Let RavenDB manage your users and logins.
https://www.nuget.org/packages/RavenDB.Identity/1.0.0
MIT License
61 stars 29 forks source link

Add SaveChanges after delete user #53

Closed luis-fss closed 9 months ago

luis-fss commented 9 months ago

RavenDB docs states that entities can be marked for deletion by using the Delete method, but will not be removed from the server until SaveChanges is called

Fix #50

JudahGabriel commented 9 months ago

Thanks for the PR. We made a conscious design decision not to call .SaveChanges/.SaveChangesAsync during these calls.

The reason is, it breaks composability and opens the door for data integrity issues. See my comment here for details.