search

Judge40 / BetterMobGriefingGameRule

"Better mobGriefing GameRule" is a Minecraft mod which improves the "mobGriefing" game rule, allowing separate values to be specified for individual types of entity.
MIT License
1 stars 1 forks source link

Server does not automatically use mobGriefing rule #22

Open stevojhall opened 6 years ago

stevojhall commented 6 years ago

Minecraft FTB Revelations server does not automatically use the S:mobGriefing=false rule, i have found that manually using the mobGriefing rule makes the other rule work as expected (i use this mod to bypass villagers being disabled from farming when using the command). This however is not the same as in single player, in single player it accepts the config file settings.

Minecraft version: 1.12.2 Forge Version: 14.23.4.2759 FTB Revelations: 2.5.0 BetterMobGriefingGameRule version: 7.0.1.j

P.S I dont think it has anything to do with FTB i just provided the info as a precaution just in case the FTB server files add something that conflicts)

Judge40 commented 5 years ago

Thanks for the report, I'll investigate when I get chance.

My initial thoughts are that it is one of the following possiblities.

  1. The world is not a new world. The default mobGriefing values for existing worlds is never changed, it is only ever done on creation. The exception here is any that are missing (such as the new entity based rules) which will be added the first time the world is loaded with the mod installed.
  2. One of the mods in FTB Revelation is changing the value after I set it upon world creation.
  3. The technique I use to determine world creation is not reliable enough.

By far the most likely is number 1, if you can confirm that is the case then I could instead look at adding an additional configuration flag to force the values upon any world start instead of only during world creation.

stevojhall commented 5 years ago

1) i have tried several times with new worlds (note 1) 2) possible, although would be server side as single player works as intended 3) i wouldn't phrase it like that but possible

Note 1, i am not pre-loading the world on my computer before putting it on the server, i load the server (with no world data) and it creates the world upon loading all mods as it does in single player (i have the console open on second monitor when playing singleplayer so i so i can see when there are problems)

On Thu, 20 Sep 2018 at 18:07, Judge40 notifications@github.com wrote:

Thanks for the report, I'll investigate when I get chance.

My initial thoughts are that it is one of the following possiblities.

  1. The world is not a new world. The default mobGriefing values for existing worlds is never changed, it is only ever done on creation. The exception here is any that are missing (such as the new entity based rules) which will be added the first time the world is loaded with the mod installed.
  2. One of the mods in FTB Revelation is changing the value after I set it upon world creation.
  3. The technique I use to determine world creation is not reliable enough.

By far the most likely is number 1, if you can confirm that is the case then I could instead look at adding an additional configuration flag to force the values upon any world start instead of only during world creation.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Judge40/BetterMobGriefingGameRule/issues/22#issuecomment-423260175, or mute the thread https://github.com/notifications/unsubscribe-auth/AX4bCA4HQ_JJm4ybD0bVLqMUQBkgVT4Rks5uc8s9gaJpZM4WwG1y .

Judge40 commented 5 years ago

I've created a local server with FTB Revelations and BetterMobGriefingGameRule with the same versions as you reported and all of the behaviour is what I would expect. I followed the following steps to verify.

  1. Start fresh FTB server and let it fully load.
  2. Run "gamerule mobGriefing" on the console - default rule = true, entity rules = inherit.
  3. Update the config file to set default = false and villager = true.
  4. Restart the server and let it fully load.
  5. Run "gamerule mobGriefing" on the console - default rule = true, entity rules = inherit.
  6. Stop the server.
  7. Delete the world.
  8. Start the server and let it fully load.
  9. Run "gamerule mobGriefing" on the console - default rule = false, villager rule = true, other entities = inherit.

What is the location of the config file you're using and have you edited the default generated one or created your own from scratch? If possible could you attach your config file so I can rule out any issues with the config itself.

The next steps after that would be to add some additional logging to the mod to try and track what is going on.

stevojhall commented 5 years ago

ah, i didn't realise the test command for finding out if mobGriefing was on or off, i used the good old fashioned spawn some creepers and see if they damage terrain.

the location is in \FTB Revelation\config, and i originally used 1 from prob a few versions back and i initially thought that it may have changed so removed it, let it gen a new 1 (it did in the same place) and could not see any changes but edited that instead.