JudicialCouncilOfCalifornia / courtyard

Judicial Council Pattern Library
GNU General Public License v2.0
6 stars 5 forks source link

Jump Nav #40

Open slowbot opened 5 years ago

slowbot commented 5 years ago

Implementation

Aside navigation with in page scroll links

As a member of the JCC Web Services team, I would like to view a “jump nav” web component in the pattern library in order for me to be able to add an aside navigation with in page scroll links.

Fields and Variants

Accessibility

jacine commented 5 years ago

These are the issues I've found:

  1. The variable for data should be changed to match the component, since it was renamed from scroll_nav to jump_nav.

  2. This component should not produce markup if there is no data. Wrapping the component in {% if jump_nav|length > 0 %} ... {% endif %} resolves this.

  3. The url_attributes line below has a bug where it is not reading the attributes from inside the array item:

    - {% set url_attributes = url_attributes ? url_attributes : create_attribute() %} %}
    + {% set url_attributes = item.url_attributes ? item.url_attributes : create_attribute() %}

Question(s)

  1. Do you know if there will be any variants for this component? Specifically, for the JumpNav in the Hero of the SRL OnRamp? If so, please let me know when it is implemented so I can make the necessary adjustments on our end.
slowbot commented 5 years ago
  1. Updated
  2. Updated
  3. Updated

Questions:

  1. No variants currently spec'd for this component.