Review

[ytaylor]

Really cool job @JuditAldeguer !!!

Here you have some tips to improve the exercise:

JavaScript: basic

• [x] Extract the feedback painter to a function.
• [x] Remove debugger and other unnecessary code

JavaScript: advanced

• [x] Move the feedback logic to a function and execute it on each click.
• [x] You are writing many times "trackEl.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'trackEl'?

Good practices

• [x] Write your code in English!
• [x] Try to improve your commit messages, better in English and using imperative.
• [x] Try to use imperative for your commit messages. Ex. - > Fix central text.
• [x] Try to improve your commits messages. "Add JS" is a bit poor. "Add random number logic" is more explanatory.

Structure

• [x] Link the external JS file correctly (watch the path!).
• [x] CSS and JS path must to start with ./.

Further challenges

Then you can improve the game as you please, here you have some ideas:

• Add new feedback when the number is bigger than 100 or smaller than 0.
• Manage when the user hits the button and the input is empty.
• Make the input work when hitting enter key.
• Add a reset button that cleans the input, the counter, writes the initial feedback and generates a new random number to play again!
• Whatever you want!

Call to action

Let me know if you have any doubts ;)

Go for it!!

Do not close this issue until your teacher asks you to

[JuditAldeguer]

Hello, @ytaylor ,

Thank you very much for your feedback!!

If I am correct, I have corrected all the tasks of the issue. Still, I am not sure if they are correct, specifically, I would like your feedback on these tasks, please:

• Extract the feedback painter to a function. --> It's done but I'd like to know if it is done correctly or if there is a better option to, in the same function, include both classList.addand clasList.remove? When I tried to include both and when there were no parameter for one of the options, JS gave me an error.
• Added Reset BTN --> could you tell me if the functions are correct or if there is an easier way to "reset" to the HTML code, with initial value / innerHTML, please?

Thank you very much in advance and, as always, if there is anything else I can do to improve, please, let me know. 😉 http://beta.adalab.es/modulo-2-evaluacion-intermedia-JuditAldeguer/

[ytaylor]

Hola Judith,

Está muy bien resuelto el issue:

• La función writeTip es correcta,
• Las funciones colorTextAdd y colorTextAdd son correctas
• Se pudiera incluir los classList.add y clasList.remove, o las funciones mencionadas en el punto anterior pudieran incluirse dentro de la función writeTip, pero no es necesario y lo haría más complicado de entender.
• La funciones para resetear el juego están muy bien hechas! Es la manera correcta!

Enhorabuena!

[JuditAldeguer]

Muchas gracias!!! :)