search

Juerd / ESP-WiFiSettings

WiFi Manager for the ESP32 Arduino environment
Other
168 stars 35 forks source link

SSID with apostrophe is truncated #7

Closed brentward closed 4 years ago

brentward commented 4 years ago

Using version 3.3.0 of the library on an ESP-WROOM-32 board, specifically the AWS ESP32 Lanyard, the SSID is being truncated at an apostrophe character.

Steps to reproduce: code:

#include <WiFiSettings.h>

void setup() {
  Serial.begin(115200);
  SPIFFS.begin(true);  // On first run, will format after failing to mount

  WiFiSettings.connect();

}

void loop() {
  Serial.println("Hello World");
  delay(2000);
}
  1. Start up device.
  2. Connect to configuration network
  3. Select the desired SSID: House Bettis's Wi-Fi Network
  4. Enter the proper password
  5. Click Save
  6. Get an error that House Bettis is not in range
Juerd commented 4 years ago

Thanks for reporting this!

I see where it went wrong: line 57 includes ' in the range of safe-to-use characters, but it should of course be escaped if I'm putting html attributes in single quotes!

I'll update it right away!

Juerd commented 4 years ago

Note: I haven't actually tested the fix but am confident that it should work now :)