search

Jugendhackt / haskell-ricochet

(WIP/Experimental) Ricochet implementation as Haskell Library.
GNU General Public License v3.0
22 stars 0 forks source link

Add wrapper module for cryptographic primitives #40

Closed photm5 closed 9 years ago

photm5 commented 9 years ago

Fixes #29. I think this is everything we need. Do you see something I missed?

photm5 commented 9 years ago

@froozen I fixed the shell.nix problem you introduced in #36, does it still work for you?

EDIT: Oops, still not fixed... Did it really work for you?

froozen commented 9 years ago

Yeah, it worked perfectly fine.

photm5 commented 9 years ago

Did you try forcing cabal to reconfigure using cabal configure? This is where the problem happens, since it seems to forget the new hprotoc version. (It errors since the old version doesn’t know the --lenses flag.)

froozen commented 9 years ago

Both cabal configure and cabal build run fine for me.

photm5 commented 9 years ago

Weird... Could you try if it still works at ca34250385ea2b81ad9803a7d9cb35c8c33c6e30?

photm5 commented 9 years ago

Oh, wait a minute, I changed the network-anonymous-tor version by accident...

froozen commented 9 years ago

shell.nix seems to be messed up in general.

photm5 commented 9 years ago

Could you try out fa93becaac1a2f80e99ce795c26e96b77bd2c031 please?

photm5 commented 9 years ago

It doesn’t help that GitHub spits out the whole commit log again whenever I change one single commit in the history.

froozen commented 9 years ago

fa93be works fine for me. The expression looks disguting, though.

froozen commented 9 years ago

What is your nix-version? I'm on 1.10.

photm5 commented 9 years ago

It does. When I first added this dirt to the codebase, I tried to refactor it myself (Using foldl, too), but failed horribly. You seem to be a bit more proficient with Nix, as you got it to work with your setup at least :)

photm5 commented 9 years ago

I’m on 1.9. However, I think the problem is not caused by our Nix versions, but rather the NixOS channel (I didn’t upgrade for a while), since Nix itself tries to stay a lot more compatible than the nixpkgs are.

froozen commented 9 years ago

Could you try upgrading and see if it works, then?

photm5 commented 9 years ago

Yes, it does work with the current Nix and Nix expressions. Finally removing that ugly Fix shell.nix commit.

froozen commented 9 years ago

Great. Yay for higher-order abstractions!

froozen commented 9 years ago

Is there a plan to add lenses for those functions? It would make sense for a lot of them.

photm5 commented 9 years ago

Do you miss any primitive or lens?

froozen commented 9 years ago

Looks good to me, you can merge. :+1: