search

Jugendhackt / haskell-ricochet

(WIP/Experimental) Ricochet implementation as Haskell Library.
GNU General Public License v3.0
22 stars 0 forks source link

Improve types #47

Closed photm5 closed 8 years ago

photm5 commented 8 years ago

This PR moves the Monad types from Monad.hs to Types.hs in order to prevent dependency loops, and to have all the types in Types. The description in Monad.hs is consequently changed to “Functions for the Ricochet Monad.”

In addition, I added hooks, which allow us to subscribe functions to channels, contact approval stages, and some Eq instances.

EDIT: Most of this is incorrect by now, see below.

sternenseemann commented 8 years ago

Looks good.

I think you've changed some files in similar ways in multiple PRs.

photm5 commented 8 years ago

I think you've changed some files in similar ways in multiple PRs.

Yeah, I just did what came to my mind, committed on my way, and splitted those commits that were initially based on each other into multiple PRs, so there might be some problems with that. I plan to merge the PRs in the order I opened them.

photm5 commented 8 years ago

I removed the commits that added hooks, as I think we’ll have to discuss the API design together in more depth beforehand. This makes the commit obsolete that moved the Monad types into the Types module, so I removed that one (Let me know whether you think it was a good thing and I should add it again.)