Jugendhackt / parteiduell-backend

https://github.com/Parteiduell/backend
MIT License
3 stars 0 forks source link

Changes to make Jugendhackt/parteiduell-frontend#18 possible #28

Open jnnkB opened 5 years ago

jnnkB commented 5 years ago

I'm currently implementing https://github.com/Jugendhackt/parteiduell-frontend/issues/18. But I need some changes to the API.

First of all, I don't need possibleAnswers, answer and statement anymore. Secondly, I'm using hashes to identify which statement should be shown. But because you are only blacking the party that is the right one, it doesn't work. I think the easiest way to fix this, would be to black the party names in the frontend.

It would be cool, if you give the parties ID's, because I currently have to save the whole name in the fragment identifier which consumes much space in the url.

Could you please fix this issue on a seperate branch, so I can test whether the frontend is working without breaking parteiduell.de? Thanks.

jnnkB commented 5 years ago

I solved the most problems in #30. But ID'S for parties are still missing.

redsolver commented 5 years ago

Nutze einfach den Parteinamen als "ID"

redsolver commented 5 years ago

@jnnkB Außerdem werden hier keine Breaking Changes in master gemerged, bevor diese nicht getestet und besprochen wurden.

jnnkB commented 5 years ago

Sorry, du hattest halt noch gar nicht geantwortet.

jnnkB commented 5 years ago

Nutze einfach den Parteinamen als "ID"

Die URL könnte halt mit richtigen ID's wesentlich kürzer sein.