search

Jugran / lyrics-in-terminal

Python curses application to view lyrics of current playing song in terminal.
MIT License
241 stars 19 forks source link

console script does not pass argv to start function, so user-specified player is ignored #2

Closed AndydeCleyre closed 4 years ago

AndydeCleyre commented 4 years ago 
$ python3 -m venv venv
$ . ./venv/bin/activate
$ pip install lyrics-in-terminal
$ lyrics ncspot
 spotify is not running!  # q

If I add these two lines to the start of start in venv/lib/python3.8/site-packages/lyrics/lyrics_in_terminal.py:

    print(f"{sys.argv=}")
    print(f"{player_name=}")
$ lyrics ncspot
 spotify is not running!  # q
sys.argv=['/home/andy/Code/newlit/venv/bin/lyrics', 'ncspot']
player_name=None
Jugran commented 4 years ago

PyPi package have been updated with the fix.