search

JuhaHeiskala / DirectQhull.jl

MIT License
12 stars 5 forks source link

Fix ConvexHull constructor, add tests #13

Closed timholy closed 9 months ago

timholy commented 9 months ago

It seems that recent changes must have added a field to ConvexHull, but the new statement was not correspondingly updated. This adds tests for construction and whether the expected vertices are returned for a simple problem.

timholy commented 9 months ago

I recommend reviewing with Files changed -> gears icon -> Hide whitespace. I have my vscode settings to automatically fix things like trailing whitespace.

JuhaHeiskala commented 9 months ago

I wonder how I have managed to not notice the missing parameter. Thanks for the test case too. I will tag this as v0.2.1

timholy commented 8 months ago

BTW, in case you're unaware, PkgTemplates is very nice when creating a new package. I usually use

tpl = Template(; plugins=[GitHubActions(), Codecov(), Documenter{GitHubActions}()])
tpl("MyNewPackage")

but there are many other tweaks you can make.

JuhaHeiskala commented 8 months ago

I think I have seen references PkgTemplates, but I haven't used it. Admittedly I am undisciplined on polishing my packages.