JuhoBjn / online-store

An online store made for a course project.
0 stars 1 forks source link

Change GHA PR workflows to checkout HEAD of the PR #65

Closed vaasuu closed 10 months ago

vaasuu commented 10 months ago

By default GHA action actions/checkout uses GITHUB_REF as the ref, which is the merge commit hash for PRs. The reason for this change is that we had a PR that when merged would fail linting check while being confusing, as the linting passed on the branch which was behind the target branch (main).

example of issue: https://github.com/JuhoBjn/online-store/actions/runs/6720164713/job/18278040362#step:5:20 (appears if commit ea5d228d66 is merged into ba314f966b)