search

Juice-Online-Judge / Juice

https://juice.cs.ccu.edu.tw
1 stars 1 forks source link

An in-range update of qs is breaking the build 🚨 #253

Open greenkeeper[bot] opened 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency qs was updated from 6.5.2 to 6.6.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

qs is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **ci/circleci:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/Juice-Online-Judge/Juice/1365?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
Commits

The new version differs by 33 commits.

  • 34af57e v6.6.0
  • 8a8028e [Dev Deps] update browserify, eslint
  • 0a2d26f [New] move two-value combine to a utils function
  • b853cb8 [refactor] stringify: Avoid arr = arr.concat(...), push to the existing instance
  • 98126ef [Fix] stringify: fix a crash with strictNullHandling and a custom filter/serializeDate
  • 58d9b3e [Tests] temporarily allow node 0.6 to fail
  • ca259b3 [Tests] up to node v11.2, v10.13, v8.13
  • 97ad647 [Dev Deps] update eslint
  • 0da164d [Fix] utils: merge: fix crash when source is a truthy primitive & no options are provided
  • ac6d4ce [Fix] stringify: do not crash when the following criteria are met:
  • 2ea1424 [Tests] up to node v10.10, v8.12
  • 9c0428c [Refactor] utils: compactQueue: make it explicitly side-effecting.
  • 6f49e1a [Refactor] parse: one less concat call
  • 62ea1e1 [Refactor] add missing defaults
  • 380568b [Refactor] parse/stringify: clean up charset options checking; fix defaults

There are 33 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 6.5.2 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.