search

Juicy / juicy-ace-editor

Custom Element with the Ace code editor
http://juicy.github.io/juicy-ace-editor/
MIT License
93 stars 34 forks source link

Pass custom events through shadow DOM boundaries #26

Closed pteck closed 7 years ago

pteck commented 7 years ago

Custom events editor-ready and change were not passed through shadow DOM boundaries so that other components could not catch them.

tomalec commented 7 years ago

Thanks for support @pteck ! Merging.

tomalec commented 7 years ago

But wait..

Is it needed? We are triggering events on the elements itself. so there is no shadow dom boundary to cross. If you want to cross the boundary in which juicy-ace-editor is in, you should do that in the author's code, shouldn't you?

pteck commented 7 years ago

As it wasn't possible to catch the events within the component, where I used juicy-ace-editor, I think it is needed.