search

Juicy / juicy-jsoneditor

Polymer Element that wraps josdejong/jsoneditor and adds two-way binding for edited JSON.
http://juicy.github.io/juicy-jsoneditor/
MIT License
42 stars 12 forks source link

Vulcanize support for external jsoneditor.css #17

Closed infiman closed 6 years ago

infiman commented 6 years ago

https://github.com/Juicy/juicy-jsoneditor/issues/16 <--- Description of the bug.

tomalec commented 6 years ago

Thanks @infiman for the PR, and sorry for the late response. I have few comments:

Also, I don't quite get why do we need to check for baseUrl.indexOf('juicy-jsoneditor') !== -1?

I'm not very familiar with Vulcanizer, but I tried to adapt your changes ad hoc, to solve above and hopefully keep Vulcanizer happy. Please check, if https://github.com/Juicy/juicy-jsoneditor/compare/bug/polymer_resolve_url works for you

infiman commented 6 years ago

Hi @tomalec, thanks for responding back! Actually, we've decided to get rid of Vulcanizer at all since soon CSS imports will be removed and HTML imports have a chance to be deprecated as well, from what I have investigated. We have moved to Webpack build system and after some struggles, we are able to build our Polymer 1 app (shame on us) in CommonJS context with polymer-webpack-loader. It solves this issue. I'm closing it, and thanks for your efforts in providing a fix.

Also, I don't quite get why do we need to check for baseUrl.indexOf('juicy-jsoneditor') !== -1?

It was made to detect either it's in vulcanized app or no.

Styles in HTML Import document are -unfortunately- deprecated even in Chrome.

Sad story... :(

You made few variables global.

Yeah, I agree, it's bad, I should have fixed that, but we needed at least some hotfix in the forked repo, so it was made in hurry. NMD, anyway, we won't need it to merge. (Thanks to Webpack).