Modify javascript formatting to support IE. Move imports to new file

Juicy / juicy-jsoneditor

Polymer Element that wraps josdejong/jsoneditor and adds two-way binding for edited JSON.

http://juicy.github.io/juicy-jsoneditor/

MIT License

42 stars 12 forks source link

Modify javascript formatting to support IE. Move imports to new file #20

Closed krumware closed 1 year ago

krumware commented 6 years ago

This PR addresses #18 and #19.

A missing function declaration and a shorthand function were modified to support Internet Explorer 11. Import files were moved into a new html file to leverage browser deduping and prevent multiple script execution.

This can be broken up into separate PRs, unless merging here is acceptable.

alshakero commented 6 years ago

Thank you so much for taking action!

LGTM, any comments @tomalec?

tomalec commented 6 years ago

Thanks for the PR! I'm totally :+1: for changing the function declarations, got some questions regarding editor and observer.

But speaking of moving imports, I think it's better to move it to separate PR, as I have more doubts there. See https://github.com/Juicy/juicy-jsoneditor/issues/19#issuecomment-362025985.

krumware commented 6 years ago

I'm totally with you on the imports, this is old pattern that may have since been resolved but we still practice (habits). Just wanted to chime in and let you guys know I haven't forgotten about this, just lots going on!