search

Juicy / juicy-jsoneditor

Polymer Element that wraps josdejong/jsoneditor and adds two-way binding for edited JSON.
http://juicy.github.io/juicy-jsoneditor/
MIT License
42 stars 12 forks source link

Switch to use josdejong/jsoneditor #4

Closed warpech closed 9 years ago

warpech commented 9 years ago

juicy-jsoneditor currently uses https://github.com/tomalec/jsoneditor/tree/102-onChangeArgumentsBuilt as the JSON tree rendering engine, which is josdejong/jsoneditor enhanced to give JSON Patch object as an argument to change callback.

As discussed between me and @tomalec on Hangouts, it should be possible to revert to upstream josdejong/jsoneditor and use obtain the JSON Patch from a different approach - for example by calling jsonpatch.compare

Reverting to use josdejong/jsoneditor will give us access to improvements made on regular base in the upstream repo.

In consequence, we will get improved JSON editor in starcounter-debug-aid

miyconst commented 9 years ago

Done. Needs some testing though. I tested on my local machine, but would be good if someone else could test.

tomalec commented 9 years ago

@miyconst getExpandState breaks text mode, please check the demo at index.html

BTW, I've added grunt-bump so to release a new version just run: (npm install) grunt bump

miyconst commented 9 years ago

Looks like fixed now. Could you check it please?

miyconst commented 9 years ago

Ping @tomalec.

warpech commented 9 years ago

Currently, bower.json defines dependency on josdejong/jsoneditor#master. It should be avoided.

Use josdejong/jsoneditor#^4.2.1

miyconst commented 9 years ago

Done.

warpech commented 9 years ago

Thanks!