search

Juicy / juicy-tile-grid

Masonry-like Custom Element for sortable tiles that packs efficiently without changing HTML structure (changes CSS only), and adapts it to CSS Grid Layout. Extended renderer for juicy-tile-list.
http://juicy.github.io/juicy-tile-grid/
MIT License
8 stars 1 forks source link

Implement "tight groups" #12

Closed tomalec closed 9 years ago

tomalec commented 9 years ago

As already mentioned in https://github.com/Polyjuice/Polyjuice/issues/42 4. and described at https://github.com/Polyjuice/Launcher/wiki/Juicy-tiles#tight--loose-groups----grid-only-construction_worker

tomalec commented 9 years ago

Wiki needs to be updated if we will merge fractions, as then instead of adaptive/dynamic we should use flexible, plus we can provide demo with flexible width, which may be more common case.

tomalec commented 9 years ago

There is one thing that we might have missed in previous discussions:

Implementing tight groups, which will behave just like nested grid, by creating nested structure in ShadowDOM to let the browser handle runtime, requires non-plain-CSS configuration for our end result.

So we will not be able to fully implement https://github.com/Polyjuice/Polyjuice/issues/42 3.2, https://github.com/Juicy/juicy-tile-list/issues/28, https://github.com/Polyjuice/Launcher/issues/99

tomalec commented 9 years ago

Done at tightGroups branch. I'll merge it to gh-pages once @miyconst agrees that tight groups + fractions #8 + first break #9 point are fair replacement for layouts composed for run-time re-packs, and that we will be able to prepare new configuration that looks better.

miyconst commented 9 years ago

Maybe I am doing something wrong again, but if I mark a group with tight checkbox, then layout messes up completely. Need a HO with @tomalec.

Edit: The tight groups work fine, the issue was a not pushed change.

tomalec commented 9 years ago

It's now at https://github.com/Juicy/juicy-tile-grid/tree/fractions