search

Juicy / juicy-tile-grid

Masonry-like Custom Element for sortable tiles that packs efficiently without changing HTML structure (changes CSS only), and adapts it to CSS Grid Layout. Extended renderer for juicy-tile-list.
http://juicy.github.io/juicy-tile-grid/
MIT License
8 stars 1 forks source link

Clean up template/shadow root inheritance #23

Closed tomalec closed 9 years ago

tomalec commented 9 years ago

It seems that currently we inherit template only, to get <div id="container"></div> as most of the styles are different. What is even worse it requires more style rules, and more hacky selectors to overwrite juicy-tile-list styles, and leads to confusing problems like #21.

I suggest to use independent template in juicy-tile-grid, especially that in latest editor's draft of Shadow DOM spec only one shadow root will be available.

With #22, almost none style rules from -list will be needed in -grid.

warpech commented 9 years ago

So juicy-tile-list will stamp out children template elements?

tomalec commented 9 years ago

I'm not sure I get what you mean. But my idea is so juicy-tile-grid will not use template/shadow root of juicy-tile-list at all.

It should be also make it easier to migrate to VanillaJS

warpech commented 9 years ago

Disregard my previous comment, I didn't get it. Now I do :) Sounds like a good idea.