search

Juicy / juicy-tile-grid

Masonry-like Custom Element for sortable tiles that packs efficiently without changing HTML structure (changes CSS only), and adapts it to CSS Grid Layout. Extended renderer for juicy-tile-list.
http://juicy.github.io/juicy-tile-grid/
MIT License
8 stars 1 forks source link

Group size is sometimes rendered wrong #24

Closed tomalec closed 9 years ago

tomalec commented 9 years ago

See http://juicy.github.io/juicy-tile-grid/examples/oversize.html it seems that https://github.com/Juicy/juicy-tile-grid/commit/67385b4814b330d2304bf65f4a3187bde8122bb0 introduced new bug

tomalec commented 9 years ago

For the first look, it seems to be Chrome CSS Grid renderer bug, as CSS properties and HTML structure are exactly the same on page load as after re-pack, but the look differs.

warpech commented 9 years ago

Here's how it looks in Canary:

screenshot 2015-08-13 12 49 43

Is that what you would expect?

tomalec commented 9 years ago

Yes, that's what is expected

warpech commented 9 years ago

So it seems to be fixed in Chrome Canary 46 (tested on Mac) and Chrome Beta 45 (tested on Win)

warpech commented 9 years ago

Are Playground apps affected?

tomalec commented 9 years ago

If we are not using group properties like, text content, backgrounds, and borders we should not notice this.

Even if we use it may not necessarily pops up.

miyconst commented 9 years ago

Chrome Version 44.0.2403.155 m:

After page load: image

After window resize: image

Chrome canary on page load: image

warpech commented 9 years ago

If we are not using group properties like, text content, backgrounds, and borders we should not notice this.

@miyconst are we using any of these, and if yes then can you check if they are broken?

miyconst commented 9 years ago

I think it won't affect the apps we are going to present, but I will double check the People app, as it has the most complex layout.

warpech commented 9 years ago

Great, then I am NOT marking this as a requirement for the Playground. Let's leave this to be resolved by Chrome update. @miyconst please update this issue if you find this is actually a problem for our apps.

warpech commented 9 years ago

Btw. Chrome 45 (which is supposed to fix it, according to our investigation) should be released within less than few weeks.