JuicyPasta / Claymore-No-Fee-Proxy

Removes Claymore's 1-2% mining fee
138 stars 67 forks source link

Excuse me, have you considered supporting the new version 9.7? - Stale share problems #7

Open mapleshadow opened 7 years ago

mapleshadow commented 7 years ago

Thanks again for your code open source :)

drdada commented 7 years ago

Hello, I will take a look ASAP, but i need time to analyze the traces and so on...

goncalossilva commented 7 years ago

If I may ask, what exactly is unsupported?

drdada commented 7 years ago

@goncalossilva We suspect Claymore is detecting our cheat. This may cause lower hashrate, stale shares, ...

Can someone provide me a comparaison of his stale share with and without the proxy (at least 12h basis) using claymore 9.7 ? I will try to do the test as well.

suspended commented 7 years ago

@drdada stale shares are at 10% with the proxy, 1% without

HavaneFr commented 7 years ago

Also 10% with the 9.6

drdada commented 7 years ago

Can you try with the new changes https://github.com/JuicyPasta/Claymore-No-Fee-Proxy/commit/3e4d0c7623c5309b009f9647567461b0f20a95fb

dhaern commented 7 years ago

How can I check stale shares?? Im testing 3e4d0c7 with fake pool dwarfpool redirects to real pool nanopool.

drdada commented 7 years ago

@dhaern Some pool show the stale shares status. Nanopool don't. Try with Ethermine.

drdada commented 7 years ago

I tested 9.7 version for hours, i thing it should be preferable to add an other way to hide the proxy. I noticed that if claymore detect a local pool (and display the warning), the claymore software will willingly add stale shares. So i recommand to use this tricks in order to hide the localhost ip address: https://github.com/JuicyPasta/Claymore-No-Fee-Proxy/wiki/Creating-a-fake-WAN-network-(Win)

Can someone help me to verify the statement ? (Reduced stale shares and no hashrate decrease)

Stale shares are shares that took too long to be sent. (Network lag,...) I reduced as it maximum the proxy latency. I also thing it can also change with pool choice. IMHO you have a lower chance to have stale shares if the pool difficulty is higher.

HavaneFr commented 7 years ago

For me it's the same problem with 9.6 Maybe create a new issue stale share"

Sent from my Samsung SM-N930F using FastHub

MichaelA2014 commented 7 years ago

I am running proxy with Claymore on a nano pool and it seem to be working just fine. Proxy is swapping the dev fee. I am not sure about stale shares. Nano pool isn't showing any. Hash rate is down when comparing running it without proxy. With proxy claymore showing around 190 mhs and without it's showing about 193 mhs @drdada Could you please write up a little more detailed how to change WAN address tutorial because I started changing and ran in to a problem. Not knowing what to put in to a default gateway. Also what pool are you mining on? Was going to use your donation wallet for devfee for a few days.

maisi commented 7 years ago

@MichaelA2014 For the static part you have to enter the same that it was before. To get the old info open a command promt (WIN + R then enter "cmd" and press enter), and type "ipconfig". Find your network adapter and the infos about IP, gateway and mask. Ideally you shouldn't use the same IP address because this could cause an IP address conflict under certain circumstances, but an IP that won't be assigned by the DHCP. For example if you had 192.168.10.1 and you have 10 devices in your home 192.168.10.30 should be safe.

MichaelA2014 commented 7 years ago

@maisi So I just go to networking, select my wireless adapter, go to preferences and ipv4 and set it to use static ip then set the desired IP? So if I wanted to spoof the ip of the dwarf pool I can just use their ipv4 and then replace 127.0.0.1 with that spoofed ip? I am sorry, networking is not my strong suit.

maisi commented 7 years ago

@MichaelA2014 You go to your wireless adapter -> IPv4 -> set the IP you found in "ipconfig" which is a private IP (like 192.168.1.10) and the subnet (most likely 255.255.255.0) and the gateway (for example 192.168.1.1), for the DNS use the gateway or the google DNS (8.8.8.8 & 8.8.4.4). Then go to advanced, click on "add" at the IP address section and enter any public IP (like 172.12.12.2) and 255.255.255.255 for the mask. Go to your hosts file and change the entry "127.0.0.1 eth-eu.dwarfpool.com" to "172.12.12.2 eth-eu.dwarfpool.com". Replace 127.0.0.1 with 172.12.12.2 when you start the script :"./stratum_proxy.py 172.12.12.2 8008 eth-eu2.nanopool.org 9999 WALLET"

MichaelA2014 commented 7 years ago

@maisi Thank you!

drdada commented 7 years ago

@MichaelA2014 I will update the wiki page with more details. Thanks in advance for the donation. (I did not think about it) You can pick Ethermine.

TheDarkCryptoMiner commented 7 years ago

I also noticed my share time doubled, so what I did was I installed a traffic shaper per application and gave proxy script and svchost (miner) higher priority. So my time went from 30ms to 62 and back down to 16-31ms accept time.

As an additional enhancement I pointed my actual pool to the wan faked address and pointed directly to the ethermine ip. That way claymore Can't get fees on the same pool. I found that even with the script it was still happening as the actual pool wasn't being intercepted.

jimmykl commented 7 years ago

@TheDarkCryptoMiner Could you please share the traffic shaper app you used?

TheDarkCryptoMiner commented 7 years ago

@jimmykl I used the turbolan utility that came with the mobo:

https://www.asus.com/support/Download/1/50/8/18/gCZCE5hKVpR1zgeo/41/ (See utilities)

TheDarkCryptoMiner commented 7 years ago

Oh. High not highest - highest didn't work. It should open a browser window for tweaking.. clicking opens cfosspeed. Click the menu option.

jimmykl commented 7 years ago

Thanks I'll check it out!

MichaelA2014 commented 7 years ago

@drdada I changed the IP and claymore stopped giving the red warning about local proxy, however reported hash and calculaterd hash went significantly down after that. Do you think claymore detects fake wan? 2017-07-17_5-54-45

drdada commented 7 years ago

@MichaelA2014 Did you reboot after the changes ? I never had any reported hashrate variation like that. And i tried with Nanopool and ethermine. Can you analyze de claymore log and see if you have any error or something (like ttdcr triggered, cable defect, on screen reported hashrate,...).

MichaelA2014 commented 7 years ago

@drdada I did reboot after changes. Everything worked fine but right off the start my indicated hashrate went from 191 down to 187. I waited... it fluctuated and then I went to sleep. Woke up my indicated hashrate was down to 138. Calculated was slightly higher. So I went back to 127.0.0.1 and hashrate became stable where it was before changes. I looked at the logs and they don't show any errors, just lower hashrate all together. Do you think claymore detect cheating with fake network?

@TheDarkCryptoMiner My claymore log shows 236-240ms share time. I would like to try the traffic shaper. Is it working with only particular asus motherboard or is it universal app? I have z270 by asus

drdada commented 7 years ago

@MichaelA2014 I can't reproduce the issue in my lab rig. Can you send me a PM in Gitter ? i will try something else. I don't think Claymore can spot so easily the fake wan and he releases the 9.7 before i came up with this tricks.

MichaelA2014 commented 7 years ago

@drdada PM sent

bri3gel commented 7 years ago

works fine for me with the fake wan ip hack. stale share are around 2-4% like before. anybody know how I can make this work so there is only one server dedicated for the python script ? at the time I run the stratum_proxy on all machines, but I would like to start the mining rigs just as usual and only my server should replace the devfee address for all of them. I could place in the local ip address, but this would increase the stale shares. I dont want to use ip spoofing. e.g. lets say I use adress 131.140.2.202, so claymore thinks it is a wan ip but it should redirect to my local server on 192.168.100.2. how can i accomplish that ?

drdada commented 7 years ago

@bri3gel You should have a full 1GB Network. Depending on the size of your farm, you should prefer create, assign and extend the fake wan network over your LAN. OR if you are familiar with linux, you can set a gateway which redirect stratum port. (In that case, you don't have to deal with fake wan tricks at all).

bri3gel commented 7 years ago

well, it is only a small server farm. so I configured my router to create a static route. everytime someone asks for the fake wan ip( e.g mining pool), it routes back to my local server with the stratum python script running it. next thing is to buy another 16 port gigabit switch instead of the old 100mbit one. anyway, thanks for the workaround