search

JujuAdams / Scribble

Efficient, internationalized, multi-effects text renderer for GameMaker
https://www.jujuadams.com/Scribble/
MIT License
321 stars 47 forks source link

Arabic Typewriter bug #484

Closed DevTRUCKer closed 11 months ago

DevTRUCKer commented 11 months ago

I think you know this bug already and you are fixing it now right?

The issue is when using Arabic typewriter it shows word after word not character after character! i think that because of Arabic is still Beta so i hope you fix it as soon as possible.

Keep up hard work am really looking forward to what you gonna make next. （＾-＾）

JujuAdams commented 11 months ago

This is a deliberate choice. Showing Arabic letter by letter would lead to visually unpleasant results due to the way Arabic glyph shaping works.

DevTRUCKer commented 11 months ago

Edit: i know its been very long time i found a fix to make arabic typewriter letter by letter but i forget completely to show here the small fix so here we are:

in scribble_get_glyph_data Script in line 106 or 107 i think you will see `for(var _i = 0xFE70; _i <= 0xFEFF; _i++) _map[? _i] = SCRIBBLE_BIDI.R2L_ARABIC; //Arabic presentation forms B just change it to for(var _i = 0xFE70; _i <= 0xFEFF; _i++) _map[? _i] = __SCRIBBLE_BIDI.R2L; //Arabic presentation forms B`

And thats if you want it but keep in mind some features can conflict with it.