JujuAdams / Scribble

Efficient, internationalized, multi-effects text renderer for GameMaker
https://www.jujuadams.com/Scribble/
MIT License
321 stars 47 forks source link

FIX for ".pause" on custom events #493

Closed Totobal5 closed 10 months ago

Totobal5 commented 10 months ago

Before this fix there was a problem with using "typist.pause" on custom events that will make the typist text be paused or not in a 50/50 fashion.

JujuAdams commented 10 months ago

Could you provide a string that would reproduce the bug you encountered please?

Totobal5 commented 10 months ago

Yeah !

but you need to make some steps first:

This example without the fix will make that the typist sometimes will stop not showing text, or sometimes it will show a single "I" that is the starting letter of the string. This problem is RNG sometimes it will happen and sometimes not.

JujuAdams commented 10 months ago

This is a good PR but made for the wrong branch. Can't figure out how to rectify that without breaking other things and it's not worth the effort for a one-line fix.

Thank you regardless!