Small typo making scribble_font_set_valign_offset() use scribble_font_set_halign_offset's settings

JujuAdams / Scribble

Efficient, internationalized, multi-effects text renderer for GameMaker

https://www.jujuadams.com/Scribble/

MIT License

335 stars 46 forks source link

Small typo making scribble_font_set_valign_offset() use scribble_font_set_halign_offset's settings #539

Closed SpookySquidGames closed 3 months ago

SpookySquidGames commented 3 months ago

Line 81 of scribble_gen_2_parser needs to be changed from: `var _state_valign_offset = _font_halign_offset_array[valign ?? _starting_valign];` to: var _state_valign_offset = _font_valign_offset_array[__valign ?? _starting_valign];\

It's causing the valign settings to be ignored and use the halign ones instead.

Also thanks so much for adding this feature! It's going to be a major quality of life upgrade for working with pixel fonts, especially for localization!

JujuAdams commented 3 months ago

lmao sorry. Could you make a PR for that?

SpookySquidGames commented 3 months ago

So, I've never done a Pull Request but I'll see if I can figure it out tomorrow.

SpookySquidGames commented 3 months ago

Ok hopefully did this correctly 😅 had a friend with more git experience walk me through it.