search

JujuAdams / basic-quaternions

Basic quaternion implementation for GameMaker
MIT License
11 stars 2 forks source link

Update library to GM 2023.8 #2

Closed CyanSorcery closed 11 months ago

CyanSorcery commented 11 months ago

Found this library while trying to figure out something. My problem ended up being unrelated so I didn't need the library, but in my quest to figure it out I ended up getting the library to work in GM 2023.8 anyways, and I saw you said a pull request would be welcomed with an updated version, so here it is

JujuAdams commented 11 months ago

Thank you for your PR but, with a quick review, I cannot accept this PR for two reasons:

  1. Substantial changes in the behaviour of the test object that I believe to be incorrect (admittedly part of the confusion is some poor programming on my behalf)
  2. Compressing multiple functions into one script

Sorry if it feels like you've wasted your time. I do appreciate you putting in the effort! I have quite a specific way that I like to format libraries to solve common issues that people run into.