JulCesWhat / TwitterAndroid

MIT License
0 stars 0 forks source link

Project Feedback! #1

Open codepathreview opened 4 years ago

codepathreview commented 4 years ago

Looks like you did not link your gif walkthrough for this assignment or it is not rendering (animating) properly when viewed in the README 😬. The gif helps us to make sure we don't miss any required or optional stories you have completed.

Render your gif:

Once you have uploaded your gif to a site like imgur you can render it using the following syntax.

<a href="/course_images/android_university/%22my_gif_address.gif%22" target="_blank"><img src='/course_images/android_university/%22my_gif_address.gif%22' title='gif_description' width='' alt='gif_description' /></a>

or

<img src="my_gif_address.gif", width=400 />

Make sure all you have completed the following steps to completing your README:

  1. Make sure you have the correct README for this assignment, go to the "Setup" section in Assignment Tab for the corresponding week in the course portal.
  2. Please mark all implemented stories [x]
  3. Add a link to your animated gif walkthrough to your README and make sure it renders (animates) when viewing the README. (Or at least works when you click on the gif link)

Your assignment is incomplete until the GIF is valid. Once resolved, please push your updates and submit your assignment again through the Course Portal (within 48 hours from the posted deadline) so we can regrade it. We will no longer review resubmissions made after this date.

Still confused about how to properly submit your assignment? Check out the Submitting Assignments for detailed instructions.

Whenever you make updates to your project that require re-grading, you need to re-submit your project using the submit button on the associated assignment page in the course portal. This will flag your project as “updated” on our end and we know to re-grade.

You should re-submit your assignment anytime you:

codepathreview commented 4 years ago

I have provided a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. /cc @codepathreview

JulCesWhat commented 4 years ago

You guys are saying that the gif is not working, but me it is working. Could you guys elaborate more in this issue?

![Uploading Screen Shot 2020-10-12 at 1.16.50 PM.png…]()

codepathreview commented 4 years ago

Looks like you did not implement the following user story/ies:

The following required user stories are complete: (Up to 5pts)

User can compose a new tweet (+5pts) User can click a "Compose" icon in the AppBar on the top right User can then enter a new tweet and post this to twitter User is taken back to home timeline with new tweet visible in timeline Newly created tweet should be manually inserted into the timeline and not rely on a full refresh User can see a counter with total number of characters left for tweet on compose tweet page

The following optional user stories are implemented: (Up to 16pts)

User can open the twitter app offline and see last loaded tweets (+2pts) Links in tweets are clickable and will launch the web browser (+1pt) User can select "reply" from detail view to respond to a tweet (+1pt) Compose activity is replaced with a modal overlay (+2pts) Use Parcelable instead of Serializable using the popular Parceler library (+1pt). Move the "Compose" action to a FloatingActionButton instead of on the AppBar. (+1pt) Enable your app to receive implicit intents from other apps. When a link is shared from a web browser, it should pre-fill the text and title of the web page when composing a tweet. (+1pt) When a user leaves the compose view without publishing and there is existing text, prompt to save or delete the draft. If saved, the draft should then be persisted to disk and can later be resumed from the compose view. (+2pts) Improve the user interface and theme the app to feel "twitter branded" (1 to 5 points)

We encourage everyone to complete all the required user stories for each assignment to demonstrate topic understanding. While we won't be regrading this submission anymore, we hope you try to complete all required user stories indicated here or on the Course Portal assignment tab for future assignments. /cc @codepathreview

codepathreview commented 3 years ago

Congrats on completing the fourth project!

I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. /cc @codepathreview