search

JulesGM / ParlAI_SearchEngine

A search engine for ParlAI's BlenderBot project (and probably other ones as well)
Creative Commons Attribution 4.0 International
132 stars 47 forks source link

Accept pull request with Bing added, 10X speed up option, cleaner web page text returned to ParlAI, command line args? #7

Open hitchingsh opened 3 years ago

hitchingsh commented 3 years ago

@JulesGM I just did a big commit on my fork and would like to submit it as a pull request if you think you'd be willing to accept it. I was wondering if you could take a look at it first and also I'm open to making suggested changes before submitting including stylistic ones like how I coded the command line args

Commit: https://github.com/hitchingsh/ParlAI_SearchEngine/commit/14f0fba2e255c8d5ef077e8ec43b7b7e50fe5194

JulesGM commented 3 years ago

Thanks for your contribution. In the state it's in, it really doesn't respect the architectural choices of the original code, and suggests that you didn't take the time to understand how the server works before making your modifications. I can't accept your pull request unless you make pretty major changes, and I can't guarantee that I would accept it unless your code really gave me the impression that you took the time to understand the server code and the choices.

JulesGM commented 3 years ago

If you split your contributions into smaller patches that I could review individually, it would be a lot better.

hitchingsh commented 3 years ago

@JulesGM I just completed the architectural and stylistic changes you requested. See the new pull request for more info.